Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent camera tests #266

Merged
merged 9 commits into from
Sep 18, 2024
Merged

Concurrent camera tests #266

merged 9 commits into from
Sep 18, 2024

Conversation

temcguir
Copy link
Collaborator

  • Make CaptureModeToggleButton more testable

    • Adds test tag to CaptureModeToggleButton
    • Adds state descriptions to ToggleButton
    • Removes unnecessary coroutine scope from ToggleButton
  • Add Concurrent Camera tests

    • Adds tests to ensure Concurrent Camera can be enabled without
      crashing the app, and appropriate features are disabled when
      concurrent camera mode is enabled.
    • Also ensures that recordings can be made in concurrent camera
      mode.

 When running JCA without an explicit intent mode, the files are
 saved to MediaStore. This installs a watch on the MediaStore to
 delete any files that are created during tests.
 Video capture seems to be saving a 3gp file without the filename
 specified. Remove the "JCA" prefix check for now in order to
 ensure this file gets deleted in tests.
@temcguir temcguir changed the title Temcguir/concurrent camera tests Concurrent camera tests Sep 17, 2024
 Adds test tag to CaptureModeToggleButton

 Adds state descriptions to ToggleButton

 Removes unnecessary coroutine scope from ToggleButton
 Adds tests to ensure Concurrent Camera can be enabled without
 crashing the app, and appropriate features are disabled when
 concurrent camera mode is enabled.

 Also ensures that recordings can be made in concurrent camera
 mode.
@temcguir temcguir force-pushed the temcguir/concurrent_camera_tests branch from d93c714 to 6a18f09 Compare September 18, 2024 00:46
Base automatically changed from temcguir/fix_mediastore_tests to main September 18, 2024 19:05
@temcguir temcguir merged commit 01fe7c4 into main Sep 18, 2024
6 checks passed
@temcguir temcguir deleted the temcguir/concurrent_camera_tests branch September 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants